Skip to content

refactor(react-router): Link component self time improvements by removing 'delete' #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sheraff merged 1 commit into from
Jan 22, 2026
Merged

refactor(react-router): Link component self time improvements by removing 'delete' #6456

Sheraff merged 1 commit into from
Jan 22, 2026
+5 −16

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Jan 22, 2026 •
edited by coderabbitai bot
Loading

On a benchmark w/ 100 concurrent requests for 30s, loading pages w/ 100 links in them, we can observe the <Link> component with a self time of > 3s. Simply removing the delete keyword, we can get this down to < 1s.

Before After
Screenshot 2026-01-22 at 21 03 18 Screenshot 2026-01-22 at 21 03 36

Summary by CodeRabbit

  • Refactor
    • Improved Link component's internal implementation for better type handling and prop management.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The Link component in react-router was refactored to simplify prop handling and conditional rendering logic. Key changes include removing innerRef extraction, adjusting the condition for plain anchor element rendering, and modifying how the disabled prop is removed during anchor creation.

Changes

Cohort / File(s) Summary
Link component refactoring
packages/react-router/src/link.tsx		 Simplified internal prop handling: removed innerRef extraction from useLinkProps, changed _asChild conditional from undefined check to falsy check (!_asChild), modified disabled prop removal to use destructuring instead of deletion, and updated final render to pass linkProps directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • TanStack/router#5590: Also modifies the Link component implementation in packages/react-router/src/link.tsx for click and target attribute handling.

Suggested labels

package: react-router

Suggested reviewers

  • birkskyum

Poem

🐰 A link that's cleaner, props that flow so neat,
No more undefined checks, the refactor's complete!
Disabled props stripped with grace, not deletion's crude way,
The anchor renders smoother, a better way to play! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: refactoring the Link component to improve performance by removing the 'delete' operation, which is directly reflected in the code changes that replace object property deletion with destructuring.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Jan 22, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8572e3b

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 11m 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-22 20:17:32 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 22, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6456

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6456

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6456

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6456

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6456

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6456

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6456

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6456

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6456

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6456

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6456

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6456

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6456

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6456

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6456

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6456

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6456

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6456

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6456

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6456

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6456

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6456

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6456

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6456

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6456

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6456

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6456

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6456

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6456

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6456

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6456

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6456

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6456

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6456

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6456

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6456

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6456

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6456

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6456

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6456

commit: 8572e3b

@Sheraff Sheraff merged commit 5d60070 into main Jan 22, 2026
6 checks passed
@Sheraff Sheraff deleted the refactor-react-router-link-component-self-time branch January 22, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: react-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sheraff